docs(material/table): additional details on table data sources #21921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(table): additional details on table data sources Provides additional documentation and clarification on extending the base DataSource class with custom data sources either by extending or implementing. Fixes angular#21887
google-cla
bot
added
the
cla: yes
Contributor
Author
|
@crisbeto - here's the PR we discussed. Feel to propose or modify anything! |
crisbeto
reviewed
Feb 16, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM with one nit. You'll also have to change the commit message title to be docs(material/table) instead of docs(table) in order for the lint check to pass.
src/material/table/table.md
Outdated
|
|
||
| Although Angular Material provides a ready-made table DataSource class, `MatTableDataSource`, you may | ||
| want to create your own custom DataSource class for more complex use cases. This can be done by | ||
| `extending` the abstract DataSource class with a custom DataSource class that then implements the |
Member
There was a problem hiding this comment.
I don't think you need the backticks around "extending" here.
s4m0r4m4
changed the title
crisbeto
approved these changes
Feb 16, 2021
Contributor
Author
|
Ok I've addressed those two issues you mentioned, let me know if there's anything else! |
crisbeto
added
docs
mmalerba
added
the
merge: fix commit message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(table): additional details on table data sources
Provides additional documentation and clarification on extending the base DataSource class with custom data sources either by extending or implementing.
Fixes #21887