Skip to content

docs: pass ElementRef<HTMLElement> as is into FocusMonitor methods #21906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

docs: pass ElementRef<HTMLElement> as is into FocusMonitor methods #21906

merged 1 commit into from
Feb 16, 2021

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Feb 15, 2021

FocusMonitor's monitor/stopMonitoring methods accept ElementRef<HTMLElement> as parameter.
So there's no need to call ElementRef.nativeElement
https://material.angular.io/cdk/a11y/api#FocusMonitor

@AlexElin
docs: pass ElementRef<HTMLElement> as is into FocusMonitor methods
a0ac192 
`FocusMonitor`'s `monitor`/`stopMonitoring` accepts `ElementRef<HTMLElement>`.
So there's no need to call `ElementRef.nativeElement`
https://material.angular.io/cdk/a11y/api#FocusMonitor
@AlexElin AlexElin requested a review from jelbourn as a code owner February 15, 2021 11:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2021
crisbeto
crisbeto approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Feb 15, 2021
@mmalerba mmalerba merged commit 176a91f into angular:master Feb 16, 2021
mmalerba pushed a commit that referenced this pull request Feb 16, 2021
@AlexElin @mmalerba
docs: pass ElementRef<HTMLElement> as is into FocusMonitor methods (#…
ccbe51e 
…21906)

`FocusMonitor`'s `monitor`/`stopMonitoring` accepts `ElementRef<HTMLElement>`.
So there's no need to call `ElementRef.nativeElement`
https://material.angular.io/cdk/a11y/api#FocusMonitor

(cherry picked from commit 176a91f)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexElin @crisbeto @mmalerba