Skip to content

feat(cdk/table): add HTML elements to sticky styler state #21704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

feat(cdk/table): add HTML elements to sticky styler state #21704

merged 1 commit into from
Feb 2, 2021

Conversation

@MichaelJamesParsons
Copy link
Collaborator

@MichaelJamesParsons MichaelJamesParsons commented Jan 26, 2021

Updates the StickyUpdate interface to optionally include the list of HTML elements that were updated. This is necessary to improve the performance of an upcoming PR that enables virtual scroll for tables.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 26, 2021
@MichaelJamesParsons MichaelJamesParsons added area: cdk/table G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Jan 26, 2021
@MichaelJamesParsons MichaelJamesParsons mentioned this pull request Jan 26, 2021
Closed
crisbeto
crisbeto approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 27, 2021
@wagnermaciel wagnermaciel merged commit 155c7c2 into angular:master Feb 2, 2021
wagnermaciel pushed a commit that referenced this pull request Feb 2, 2021
@MichaelJamesParsons @wagnermaciel
feat(cdk/table): add HTML elements to sticky styler update (#21704)
d0106c1 
(cherry picked from commit 155c7c2)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@MichaelJamesParsons @wagnermaciel
feat(cdk/table): add HTML elements to sticky styler update (angular#2…
ff72a2f 
…1704)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@MichaelJamesParsons @wagnermaciel
feat(cdk/table): add HTML elements to sticky styler update (angular#2…
3c08fcc 
…1704)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 5, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/table cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelJamesParsons @crisbeto @wagnermaciel