build: fix error from latest MDC canary #21663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
a team,
andrewseguin and
jelbourn
as code owners
google-cla
bot
added
the
cla: yes
The latest MDC canary version introduced its own types for `ResizeObserver` which broke our code. These changes remove the polyfilled types and use MDC's instead.
crisbeto
force-pushed
the
mdc-resize-observer-error
branch
from
1cd87c5 to
c86bf7f
Compare
This was referenced Jan 21, 2021
andrewseguin
pushed a commit
that referenced
this pull request
Jan 21, 2021
The latest MDC canary version introduced its own types for `ResizeObserver` which broke our code. These changes remove the polyfilled types and use MDC's instead. (cherry picked from commit acb3f33)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 26, 2021
The latest MDC canary version introduced its own types for `ResizeObserver` which broke our code. These changes remove the polyfilled types and use MDC's instead.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
The latest MDC canary version introduced its own types for `ResizeObserver` which broke our code. These changes remove the polyfilled types and use MDC's instead.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
The latest MDC canary version introduced its own types for `ResizeObserver` which broke our code. These changes remove the polyfilled types and use MDC's instead.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest MDC canary version introduced its own types for
ResizeObserverwhich broke our code. These changes remove the polyfilled types and use MDC's instead.