Skip to content

fix(material/tooltip): not closing when clicking outside using auxiliary button #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

fix(material/tooltip): not closing when clicking outside using auxiliary button #21467

merged 1 commit into from
Jan 19, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 29, 2020

Similar to #21397. Fixes that the tooltip doesn't close when the user presses outside using the middle or right mouse button.

@crisbeto
fix(material/tooltip): not closing when clicking outside using auxili…
28f4f80 
…ary button

Similar to angular#21397. Fixes that the tooltip doesn't close when the user presses outside
using the middle or right mouse button.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 29, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2020
andrewseguin
andrewseguin approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2021
@mmalerba mmalerba merged commit ddf99cb into angular:master Jan 19, 2021
mmalerba pushed a commit that referenced this pull request Jan 19, 2021
@crisbeto @mmalerba
fix(material/tooltip): not closing when clicking outside using auxili…
27bb590 
…ary button (#21467)

Similar to #21397. Fixes that the tooltip doesn't close when the user presses outside
using the middle or right mouse button.

(cherry picked from commit ddf99cb)
mmalerba pushed a commit that referenced this pull request Jan 19, 2021
@crisbeto @mmalerba
fix(material/tooltip): not closing when clicking outside using auxili…
01cbebe 
…ary button (#21467)

Similar to #21397. Fixes that the tooltip doesn't close when the user presses outside
using the middle or right mouse button.

(cherry picked from commit ddf99cb)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 20, 2021
@crisbeto @wagnermaciel
fix(material/tooltip): not closing when clicking outside using auxili…
dc8b710 
…ary button (angular#21467)

Similar to angular#21397. Fixes that the tooltip doesn't close when the user presses outside
using the middle or right mouse button.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @andrewseguin @mmalerba