Skip to content

fix(cdk/tree): add missing generic types to trackBy Fixes (#21364) #21421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2021
Merged

fix(cdk/tree): add missing generic types to trackBy Fixes (#21364) #21421

merged 2 commits into from
Jan 6, 2021

Conversation

@POFerro
Copy link
Contributor

@POFerro POFerro commented Dec 22, 2020

No description provided.

@POFerro POFerro requested review from a team, andrewseguin and jelbourn as code owners December 22, 2020 16:35
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 22, 2020
crisbeto
crisbeto approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 23, 2020
@crisbeto crisbeto mentioned this pull request Dec 23, 2020
Closed
@annieyw annieyw merged commit 22d5600 into angular:master Jan 6, 2021
annieyw pushed a commit that referenced this pull request Jan 6, 2021
@POFerro @annieyw
fix(cdk/tree): add missing generic types to trackBy Fixes (#21364) (#…
6318d11 
…21421)

* fix(cdk/tree): add missing generic types to trackBy Fixes (#21364)

* fix(cdk/tree): add missing generic types to trackBy Fixes (#21364)

(cherry picked from commit 22d5600)
@POFerro POFerro deleted the pof_fix_21364 branch January 7, 2021 13:23
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@POFerro @wagnermaciel
fix(cdk/tree): add missing generic types to trackBy Fixes (angular#21364
4c4231d 
) (angular#21421)

* fix(cdk/tree): add missing generic types to trackBy Fixes (angular#21364)

* fix(cdk/tree): add missing generic types to trackBy Fixes (angular#21364)
@rafaelss95 rafaelss95 mentioned this pull request Jan 14, 2021
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 7, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@POFerro @crisbeto @annieyw