refactor(google-maps): clean up internal setup #21079
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Reworks the internal setup of the `google-map` component so that we don't have to declare observables for each input.
crisbeto
force-pushed
the
google-map-refactor
branch
from
14ca61f to
6e944ee
Compare
| this._setSize(); | ||
| } | ||
|
|
||
| const googleMap = this.googleMap; |
There was a problem hiding this comment.
All things being equal, I think we may as well just continue to reference this.googleMap instead of reassigning it to a local variable.
There was a problem hiding this comment.
It's a bit of a micro-optimization, but I wrote it this way because it'll minify better with most common minifiers that don't do property renaming.
There was a problem hiding this comment.
Can you add a comment saying that was the reason for doing this?
| this._setSize(); | ||
| } | ||
|
|
||
| const googleMap = this.googleMap; |
There was a problem hiding this comment.
Can you add a comment saying that was the reason for doing this?
Reworks the internal setup of the `google-map` component so that we don't have to declare observables for each input. (cherry picked from commit 28c36f8)
Reworks the internal setup of the `google-map` component so that we don't have to declare observables for each input. (cherry picked from commit 28c36f8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Reworks the internal setup of the
google-mapcomponent so that we don't have to declare observables for each input.