Skip to content

feat(material/core): add typography config normalization function #21059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

feat(material/core): add typography config normalization function #21059

merged 2 commits into from
Dec 3, 2020

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 16, 2020

No description provided.

@mmalerba mmalerba requested a review from jelbourn November 16, 2020 18:25
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 16, 2020
@mmalerba
fix(material/core): add typography config normalization function
db83f06 
Future PRs will adopt this function in the typography mixins for our
components
@mmalerba mmalerba added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Nov 25, 2020
@mmalerba mmalerba marked this pull request as ready for review November 25, 2020 20:00
@mmalerba mmalerba requested a review from crisbeto as a code owner November 25, 2020 20:00
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 25, 2020
crisbeto
crisbeto reviewed Nov 25, 2020
View reviewed changes
crisbeto
crisbeto approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 26, 2020
@mmalerba mmalerba merged commit 1a6f9f4 into angular:master Dec 3, 2020
mmalerba added a commit that referenced this pull request Dec 3, 2020
@mmalerba
feat(material/core): add typography config normalization function (#2…
6830350 
…1059)

* fix(material/core): add typography config normalization function

Future PRs will adopt this function in the typography mixins for our
components

* fixup! fix(material/core): add typography config normalization function

(cherry picked from commit 1a6f9f4)
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 11, 2020
@mmalerba
refactor(material/core): make typography normalization function private
1e4a1b5 
This was mistakenly made public in angular#21059
@mmalerba mmalerba mentioned this pull request Dec 11, 2020
Merged
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 11, 2020
@mmalerba
fix(material-experimental/mdc-autocomplete): Allow typography mixin t…
c72b618 
…o consume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 11, 2020
@mmalerba
fix(material-experimental/mdc-autocomplete): Allow typography mixin t…
ada70fd 
…o consume 2018 style configs

See angular#21059 for context.
mmalerba added a commit that referenced this pull request Dec 12, 2020
@mmalerba
refactor(material/core): make typography normalization function priva…
89d5790 
…te (#21286)

This was mistakenly made public in #21059
mmalerba added a commit that referenced this pull request Dec 12, 2020
@mmalerba
refactor(material/core): make typography normalization function priva…
c6231e1 
…te (#21286)

This was mistakenly made public in #21059

(cherry picked from commit 89d5790)
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-autocomplete): Allow typography mixin t…
3622d12 
…o consume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-button): Allow typography mixin to cons…
f2d8870 
…ume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-card): Allow typography mixin to consum…
4d5bcde 
…e 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-checkbox): Allow typography mixin to co…
adcbe54 
…nsume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-chips): Allow typography mixin to consu…
b557726 
…me 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-core): Allow typography mixin to consum…
f7983eb 
…e 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-core): Allow typography mixin to consum…
15c0473 
…e 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-dialog): Allow typography mixin to cons…
283d0a7 
…ume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 12, 2020
@mmalerba
fix(material-experimental/mdc-form-field): Allow typography mixin to …
14b3778 
…consume 2018 style configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/card): Allow typography mixin to consume 2018 style configs
ddd7311 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/checkbox): Allow typography mixin to consume 2018 style …
c633173 
…configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/chips): Allow typography mixin to consume 2018 style con…
78de3a5 
…figs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/core): Allow typography mixin to consume 2018 style configs
d3420e2 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/core): Allow typography mixin to consume 2018 style configs
6b59ccc 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/datepicker): Allow typography mixin to consume 2018 styl…
f309aa6 
…e configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/dialog): Allow typography mixin to consume 2018 style co…
0f01fc0 
…nfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/expansion): Allow typography mixin to consume 2018 style…
7b310f6 
… configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/form-field): Allow typography mixin to consume 2018 styl…
a1ed2e8 
…e configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/form-field): Allow typography mixin to consume 2018 styl…
36901ab 
…e configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/form-field): Allow typography mixin to consume 2018 styl…
1acc2a5 
…e configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/form-field): Allow typography mixin to consume 2018 styl…
8b705d8 
…e configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/grid-list): Allow typography mixin to consume 2018 style…
2c47ecb 
… configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/input): Allow typography mixin to consume 2018 style con…
1c2e601 
…figs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/list): Allow typography mixin to consume 2018 style configs
fe35b18 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/menu): Allow typography mixin to consume 2018 style configs
17498fc 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/paginator): Allow typography mixin to consume 2018 style…
b71b516 
… configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/radio): Allow typography mixin to consume 2018 style con…
28d3809 
…figs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/select): Allow typography mixin to consume 2018 style co…
1456715 
…nfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/slide-toggle): Allow typography mixin to consume 2018 st…
a7d3dc4 
…yle configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/slider): Allow typography mixin to consume 2018 style co…
c57a2a7 
…nfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/snack-bar): Allow typography mixin to consume 2018 style…
f798d9f 
… configs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/stepper): Allow typography mixin to consume 2018 style c…
7044058 
…onfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/table): Allow typography mixin to consume 2018 style con…
8aa89d4 
…figs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/tabs): Allow typography mixin to consume 2018 style configs
2441996 
See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/toolbar): Allow typography mixin to consume 2018 style c…
6c1b2df 
…onfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/tooltip): Allow typography mixin to consume 2018 style c…
c063917 
…onfigs

See angular#21059 for context.
mmalerba added a commit to mmalerba/components that referenced this pull request Dec 14, 2020
@mmalerba
fix(material/tree): Allow typography mixin to consume 2018 style configs
f88523d 
See angular#21059 for context.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 3, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmalerba @crisbeto