fix(material/dialog): incorrect action height if box-sizing is configured globally #20889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ured globally
It's common for apps to set `* { box-sizing: border-box; }` at a global level which ends up
breaking the styles of our dialog. These changes set an explicit `box-sizing` to ensure
that it still looks consistently. This is in line with what we've done in other similar cases.
Fixes angular#20887.
crisbeto
added
P4
google-cla
bot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
…ured globally (#20889) It's common for apps to set `* { box-sizing: border-box; }` at a global level which ends up breaking the styles of our dialog. These changes set an explicit `box-sizing` to ensure that it still looks consistently. This is in line with what we've done in other similar cases. Fixes #20887. (cherry picked from commit 43b463f)
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
…ured globally (#20889) It's common for apps to set `* { box-sizing: border-box; }` at a global level which ends up breaking the styles of our dialog. These changes set an explicit `box-sizing` to ensure that it still looks consistently. This is in line with what we've done in other similar cases. Fixes #20887. (cherry picked from commit 43b463f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for apps to set
* { box-sizing: border-box; }at a global level which ends up breaking the styles of our dialog. These changes set an explicitbox-sizingto ensure that it still looks consistently. This is in line with what we've done in other similar cases.Fixes #20887.