Skip to content

Conversation

@wagnermaciel
Copy link
Contributor

…t on ElementFinder

  • Internally this was causing an error saying that the type has a
    string index signature, but it is being accessed using a dotted property access.

…t on ElementFinder

 * Internally this was causing an error saying that the type has a
  string index signature, but it is being accessed using a dotted property access.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2020
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for devversion October 8, 2020 19:53
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Oct 8, 2020
@wagnermaciel wagnermaciel merged commit 7d99c35 into angular:master Oct 9, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2020
@wagnermaciel wagnermaciel deleted the small-fix branch January 14, 2021 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants