Skip to content

Revert "fix(material/slider): some screen readers announcing long dec… #20753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Revert "fix(material/slider): some screen readers announcing long dec… #20753

merged 1 commit into from
Oct 8, 2020

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Oct 8, 2020

…imal values (#20721)"

This reverts commit d93e16f.

Had to revert this change because a custom aria-valuetext on the component should override what the component sets

@wagnermaciel wagnermaciel requested a review from mmalerba as a code owner October 8, 2020 19:10
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2020
jelbourn
jelbourn approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 8, 2020
@wagnermaciel wagnermaciel merged commit a217509 into master Oct 8, 2020
wagnermaciel added a commit that referenced this pull request Oct 8, 2020
@wagnermaciel
Revert "fix(material/slider): some screen readers announcing long dec…
e3445d6 
…imal values (#20721)" (#20753)

This reverts commit d93e16f.

(cherry picked from commit a217509)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 8, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2020
@mmalerba mmalerba deleted the revert-20721 branch November 13, 2020 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagnermaciel @jelbourn