Skip to content

refactor(cdk/tree): remove deprecated APIs for v11 #20573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

refactor(cdk/tree): remove deprecated APIs for v11 #20573

merged 1 commit into from
Sep 22, 2020

Conversation

crisbeto
Copy link
Member

Removes the APIs that were marked as deprecated for v11 in the tree module.

BREAKING CHANGES:

  • _renderer parameter of the CdkTreeNodePadding constructor has been removed.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 15, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Sep 15, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2020
jelbourn
jelbourn approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2020
@crisbeto
refactor(cdk/tree): remove deprecated APIs for v11
ba7b3f5 
Removes the APIs that were marked as deprecated for v11 in the tree module.

BREAKING CHANGES:
* `_renderer` parameter of the `CdkTreeNodePadding` constructor has been removed.
@crisbeto crisbeto force-pushed the tree-v11-breaking-changes branch from cd85e02 to ba7b3f5 Compare September 17, 2020 18:50
@annieyw annieyw merged commit 8c2838d into angular:master Sep 22, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees

@devversion devversion

@mmalerba mmalerba

@wagnermaciel wagnermaciel

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@crisbeto @jelbourn @devversion @googlebot @mmalerba @annieyw @wagnermaciel