Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 5, 2020

Changes the APIs that were marked as deprecated for v11.

BREAKING CHANGES:

  • _scrollDispatcher parameter of the CdkDropList constructor is now required. Also the order of the parameters has changed to accommodate the parameter becoming required.
  • previousIndex parameter of DropListRef.drop is now required. Also the parameter order has changed.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 5, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Sep 5, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 5, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2020
@wagnermaciel
Copy link
Contributor

@crisbeto Please resolve this merge conflict. Seems to conflict with #20389

Changes the APIs that were marked as deprecated for v11.

BREAKING CHANGES:
* `_scrollDispatcher` parameter of the `CdkDropList` constructor is now required. Also the order of the parameters has changed to accommodate the parameter becoming required.
* `previousIndex` parameter of `DropListRef.drop` is now required. Also the parameter order has changed.
@crisbeto crisbeto force-pushed the drag-drop-v11-breaking-changes branch from fa4c754 to 21e0358 Compare September 16, 2020 15:21
@crisbeto
Copy link
Member Author

Rebased.

@wagnermaciel wagnermaciel merged commit f8ab9ba into angular:master Sep 16, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants