refactor(tabs): remove deprecated APIs for v11 #20499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
tabs-v11-breaking-changes
branch
from
13fa73d to
cb5bbb8
Compare
crisbeto
force-pushed
the
tabs-v11-breaking-changes
branch
from
cb5bbb8 to
4b05f98
Compare
|
@crisbeto Please resolve this merge conflict |
crisbeto
force-pushed
the
tabs-v11-breaking-changes
branch
from
4b05f98 to
3f954be
Compare
|
Rebased. |
Removes the APIs that were marked for removal in v11. There are also a few cases of the `_animationMode` parameter that I decided to keep optional since there's no good reason for it to be required. BREAKING CHANGES: * The `_element` parameter has been removed from `MatTabNav.updateActiveLink`. * `_platform` parameter of the `MatPaginatedTabHeader` constructor is now required. * `_document` parameter of the `MatTabBodyPortal` constructor is now required. * `platform` parameter of the `MatTabNav` constructor is now required. * `_closestTabGroup` parameter of the `MatTab` constructor is now required.
crisbeto
force-pushed
the
tabs-v11-breaking-changes
branch
from
3f954be to
5a36b5c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the APIs that were marked for removal in v11. There are also a few cases of the
_animationModeparameter that I decided to keep optional since there's no good reason for it to be required.BREAKING CHANGES:
_elementparameter has been removed fromMatTabNav.updateActiveLink._platformparameter of theMatPaginatedTabHeaderconstructor is now required._documentparameter of theMatTabBodyPortalconstructor is now required.platformparameter of theMatTabNavconstructor is now required._closestTabGroupparameter of theMatTabconstructor is now required.