refactor(chips): remove deprecated APIs for v11 #20463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the APIs that were marked for deprecation in v11. I also decided to un-deprecate making the `animationMode` parameters required, because there's no good reason for them to be mandatory. BREAKING CHANGES: * `_changeDetectorRef` and `_document` parameters of the `MatChip` constructor are now required. Also the order of some constructor parameters has changed. * `elementRef` parameter of the `MatChipRemove` constructor is now required.
crisbeto
added
P2
crisbeto
requested review from
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Sep 5, 2020
Removes the APIs that were marked for deprecation in v11. I also decided to un-deprecate making the `animationMode` parameters required, because there's no good reason for them to be mandatory. BREAKING CHANGES: * `_changeDetectorRef` and `_document` parameters of the `MatChip` constructor are now required. Also the order of some constructor parameters has changed. * `elementRef` parameter of the `MatChipRemove` constructor is now required.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the APIs that were marked for deprecation in v11. I also decided to un-deprecate making the
animationModeparameters required, because there's no good reason for them to be mandatory.BREAKING CHANGES:
_changeDetectorRefand_documentparameters of theMatChipconstructor are now required. Also the order of some constructor parameters has changed.elementRefparameter of theMatChipRemoveconstructor is now required.