Skip to content

Conversation

crisbeto
Copy link
Member

BREAKING CHANGES:

  • The document parameter of the ScrollDispatcher constructor is now required.
  • The document parameter of the ViewportRuler constructor is now required.
  • The viewportRuler parameter of the CdkVirtualScrollViewport constructor is now required.

Also bumps two autocomplete APIs that were only marked as deprecated 10 days ago to v12 instead of v11.

BREAKING CHANGES:
* The `document` parameter of the `ScrollDispatcher` constructor is now required.
* The `document` parameter of the `ViewportRuler` constructor is now required.
* The `viewportRuler` parameter of the `CdkVirtualScrollViewport` constructor is now required.

Also bumps two autocomplete APIs that were only marked as deprecated 10 days ago to v12 instead of v11.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 29, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Aug 29, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 29, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 31, 2020
@mmalerba mmalerba merged commit d987587 into angular:master Sep 2, 2020
mmalerba pushed a commit to mmalerba/components that referenced this pull request Sep 5, 2020
BREAKING CHANGES:
* The `document` parameter of the `ScrollDispatcher` constructor is now required.
* The `document` parameter of the `ViewportRuler` constructor is now required.
* The `viewportRuler` parameter of the `CdkVirtualScrollViewport` constructor is now required.

Also bumps two autocomplete APIs that were only marked as deprecated 10 days ago to v12 instead of v11.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants