Skip to content

build: fix lint failure #20378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

build: fix lint failure #20378

merged 1 commit into from
Aug 21, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 21, 2020 •
edited
Loading

Fixes a lint failure due to a few PRs landing at the same time where one introduces a new lint rule.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 21, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2020
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 21, 2020
@crisbeto crisbeto force-pushed the ng-dev-mode-lint-failure branch from 0a55862 to 54743a5 Compare August 21, 2020 06:12
@crisbeto
build: fix lint failure
afae9c1 
Fixes a lint failure due to a few PRs landing in at the same time where one introduces a new lint rule.
@crisbeto crisbeto force-pushed the ng-dev-mode-lint-failure branch from 54743a5 to afae9c1 Compare August 21, 2020 06:14
devversion
devversion approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (See I even added a todo 😌)

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 21, 2020
@wagnermaciel wagnermaciel merged commit f0c7a25 into angular:master Aug 21, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 21, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @devversion @googlebot @wagnermaciel