Skip to content

Revert "perf(int-bar): Convert MatInkBarFoundation adapter to class o… #20051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

Revert "perf(int-bar): Convert MatInkBarFoundation adapter to class o… #20051

merged 1 commit into from
Jul 21, 2020

Conversation

@wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Jul 21, 2020

…bject (#19986)"

This reverts commit 78dc50b.

This PR was marked merge-safe but caused presubmits to break.
Tests were failing because the dev-app doesn't show ink bars anymore.

@wagnermaciel
Revert "perf(int-bar): Convert MatInkBarFoundation adapter to class o…
3d62ea6 
…bject (angular#19986)"

This reverts commit 78dc50b.

This PR was marked merge-safe but caused presubmits to break.
Tests were failing because the dev-app doesn't show ink bars anymore.
@wagnermaciel wagnermaciel requested a review from crisbeto as a code owner July 21, 2020 03:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2020
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 21, 2020
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Jul 21, 2020
@wagnermaciel wagnermaciel merged commit 4a1b24c into angular:master Jul 21, 2020
wagnermaciel added a commit that referenced this pull request Jul 21, 2020
@wagnermaciel
Revert "perf(int-bar): Convert MatInkBarFoundation adapter to class o…
c9aeb30 
…bject (#19986)" (#20051)

This reverts commit 78dc50b.

This PR was marked merge-safe but caused presubmits to break.
Tests were failing because the dev-app doesn't show ink bars anymore.

(cherry picked from commit 4a1b24c)
andrewseguin pushed a commit that referenced this pull request Jul 21, 2020
@wagnermaciel @andrewseguin
Revert "perf(int-bar): Convert MatInkBarFoundation adapter to class o…
010b920 
…bject (#19986)" (#20051)

This reverts commit 78dc50b.

This PR was marked merge-safe but caused presubmits to break.
Tests were failing because the dev-app doesn't show ink bars anymore.

(cherry picked from commit 4a1b24c)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 21, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2020
@wagnermaciel wagnermaciel deleted the revert-inkbar-change branch January 14, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wagnermaciel @andrewseguin @googlebot