test: fix failing MDC snackbar test #19974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MDC-based snackbar tests are currently failing because we landed a change in the non-MDC snackbar that propagates to the MDC-based snack bar. That is expected, but the test for the MDC-based snackbar have not been updated accordingly. See: angular@1bbfcf4.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
approved these changes
Jul 14, 2020
andrewseguin
added
lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jul 14, 2020
The MDC-based snackbar tests are currently failing because we landed a change in the non-MDC snackbar that propagates to the MDC-based snack bar. That is expected, but the test for the MDC-based snackbar have not been updated accordingly. See: 1bbfcf4.
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
The MDC-based snackbar tests are currently failing because we landed a change in the non-MDC snackbar that propagates to the MDC-based snack bar. That is expected, but the test for the MDC-based snackbar have not been updated accordingly. See: angular@1bbfcf4.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDC-based snackbar tests are currently failing because we landed
a change in the non-MDC snackbar that propagates to the MDC-based
snack bar. That is expected, but the test for the MDC-based snackbar
have not been updated accordingly.
See: 1bbfcf4.