Skip to content

build: fix wrong directory for notification script #19626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

build: fix wrong directory for notification script #19626

merged 1 commit into from
Jun 12, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 12, 2020

The path to the Slack notification script seems to be incorrect.

@crisbeto
build: fix wrong directory for notification script
6882bb5 
The path to the Slack notification script seems to be incorrect.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 12, 2020
@crisbeto crisbeto requested a review from a team June 12, 2020 18:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 12, 2020
@josephperrott josephperrott requested review from devversion and removed request for a team June 12, 2020 18:12
josephperrott
josephperrott reviewed Jun 12, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting for @devversion to review

devversion
devversion approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang! Can't believe I got that wrong 😄 Unfortunately this doesn't run on PRs so I didn't realize.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 12, 2020
@andrewseguin andrewseguin merged commit 366852c into angular:master Jun 12, 2020
andrewseguin pushed a commit that referenced this pull request Jun 12, 2020
@crisbeto @andrewseguin
build: fix wrong directory for notification script (#19626)
34cd8ee 
The path to the Slack notification script seems to be incorrect.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott left review comments

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @devversion @josephperrott @googlebot @andrewseguin