Skip to content

docs(a11y): add note about cdkFocusInitial inside focus trap directive #19560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

docs(a11y): add note about cdkFocusInitial inside focus trap directive #19560

merged 1 commit into from
Jun 9, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2020

Adds a note to the docs mentioning that cdkFocusInitial won't do anything inside the focus trap directive, unless cdkTrapFocusAutoCapture is enabled.

Fixes #19475.

@crisbeto
docs(a11y): add note about cdkFocusInitial inside focus trap directive
c1b2347 
Adds a note to the docs mentioning that `cdkFocusInitial` won't do anything inside the focus trap directive, unless `cdkTrapFocusAutoCapture` is enabled.

Fixes angular#19475.
@crisbeto crisbeto added docs This issue is related to documentation merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jun 7, 2020
jelbourn
jelbourn approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 8, 2020
@andrewseguin andrewseguin added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 9, 2020
@andrewseguin andrewseguin merged commit 2160cca into angular:master Jun 9, 2020
andrewseguin pushed a commit that referenced this pull request Jun 9, 2020
@crisbeto @andrewseguin
docs(a11y): add note about cdkFocusInitial inside focus trap directive (
5b36bdd 
#19560)

Adds a note to the docs mentioning that `cdkFocusInitial` won't do anything inside the focus trap directive, unless `cdkTrapFocusAutoCapture` is enabled.

Fixes #19475.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 10, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs-bug([FocusTrap]): [Leak documentation about cdkTrapFocusAutoCapture]

5 participants

@crisbeto @jelbourn @devversion @mmalerba @andrewseguin