build: do not print github auth token if merge script fails #19159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
merge-script-imprv
branch
2 times, most recently
from
3e3d067 to
6371f61
Compare
Various improvements to the merge script: 1. No longer print Github auth token if a command fails. 2. No longer print Github auth token when verbose-printing executed git commands. 3. Better error if token does not have required permissions for merging pull request (api-merge strategy)
devversion
force-pushed
the
merge-script-imprv
branch
from
6371f61 to
ccabd04
Compare
jelbourn
approved these changes
Apr 23, 2020
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM, @josephperrott will probably want to take a look
jelbourn
pushed a commit
that referenced
this pull request
Apr 23, 2020
Various improvements to the merge script: 1. No longer print Github auth token if a command fails. 2. No longer print Github auth token when verbose-printing executed git commands. 3. Better error if token does not have required permissions for merging pull request (api-merge strategy)
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…19159) Various improvements to the merge script: 1. No longer print Github auth token if a command fails. 2. No longer print Github auth token when verbose-printing executed git commands. 3. Better error if token does not have required permissions for merging pull request (api-merge strategy)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the merge script:
pull request (api-merge strategy)