fix(material-experimental/mdc-radio): avoid bundling styles from base radio button #19032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… radio button The MDC-based radio button currently extends the `MatRadioButton` directly which means that the styles and template from the base will be bundled together with the MDC one. These changes move all of the functionality into an undecorated base class which is then extended by the two button variants.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
approved these changes
Apr 9, 2020
Contributor
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
Ah, I'm sure this explains some of the size regression we saw. Good catch!
mmalerba
added
lgtm
action: merge
devversion
approved these changes
Apr 9, 2020
| /** | ||
| * A Material design radio-button. Typically placed inside of `<mat-radio-group>` elements. | ||
| * Base class with all of the `MatRadioButton` functionality. | ||
| * @docs-private |
Member
There was a problem hiding this comment.
FWIW: docs-private should not be needed here as the class is prefixed with an underscore. Doesn't hurt though.
jelbourn
pushed a commit
that referenced
this pull request
Apr 20, 2020
… radio button (#19032) The MDC-based radio button currently extends the `MatRadioButton` directly which means that the styles and template from the base will be bundled together with the MDC one. These changes move all of the functionality into an undecorated base class which is then extended by the two button variants. (cherry picked from commit 506b74a)
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
… radio button (angular#19032) The MDC-based radio button currently extends the `MatRadioButton` directly which means that the styles and template from the base will be bundled together with the MDC one. These changes move all of the functionality into an undecorated base class which is then extended by the two button variants.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDC-based radio button currently extends the
MatRadioButtondirectly which means that the styles and template from the base will be bundled together with the MDC one. These changes move all of the functionality into an undecorated base class which is then extended by the two button variants.