Skip to content

fix(tree): complete viewChange stream on destroy #18991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix(tree): complete viewChange stream on destroy #18991

merged 1 commit into from
Apr 24, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 4, 2020

Fixes the tree not completing its viewChange stream.

@crisbeto
fix(tree): complete viewChange stream on destroy
16ac69e 
Fixes the tree not completing its `viewChange` stream.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Apr 4, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2020
jelbourn
jelbourn approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 23, 2020
@jelbourn jelbourn merged commit 403a3d1 into angular:master Apr 24, 2020
jelbourn pushed a commit that referenced this pull request Apr 24, 2020
@crisbeto @jelbourn
fix(tree): complete viewChange stream on destroy (#18991)
d7d3be1 
Fixes the tree not completing its `viewChange` stream.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
fix(tree): complete viewChange stream on destroy (angular#18991)
939da07 
Fixes the tree not completing its `viewChange` stream.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 25, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @googlebot