build: sanitize postinstall patch markers #18982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarn throws if patch markers with special characters are found in restored `node_modules`. To fix this, patch markers are now sanitized to not contain special characters.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
14 tasks
jelbourn
approved these changes
Apr 3, 2020
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Should we file a bug with yarn?
Member
Author
|
@jelbourn Yep. Created an issue upstream: yarnpkg/yarn#8044. |
mmalerba
pushed a commit
that referenced
this pull request
Apr 14, 2020
Yarn throws if patch markers with special characters are found in restored `node_modules`. To fix this, patch markers are now sanitized to not contain special characters.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn throws if patch markers with special characters are found
in restored
node_modules. To fix this, patch markers are nowsanitized to not contain special characters.