Skip to content

Revert "refactor: change isDateInstance return type to is D" #18897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Revert "refactor: change isDateInstance return type to is D" #18897

merged 1 commit into from
Mar 23, 2020

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 23, 2020

Reverts #18786

@mmalerba mmalerba requested a review from jelbourn as a code owner March 23, 2020 17:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2020
@mmalerba
Copy link
Contributor Author

mmalerba commented Mar 23, 2020

@DevTrong sorry I realized that this is actually a breaking API change - we will have to wait until a major release to make this change, and we'll need schematics to migrate users. Please feel free to open a new PR.

crisbeto
crisbeto approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 23, 2020
@mmalerba mmalerba merged commit 16e2cf0 into master Mar 23, 2020
@mmalerba mmalerba deleted the revert-18786-refactor-isdateinstance branch March 23, 2020 22:02
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 23, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba @crisbeto @devversion @googlebot