Skip to content

feat(material/icon): allow fetching icons with credentials #18896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

feat(material/icon): allow fetching icons with credentials #18896

merged 1 commit into from
Apr 8, 2020

Conversation

@jchv
Copy link
Contributor

@jchv jchv commented Mar 23, 2020

Adds the ability to fetch SVG icons using withCredentials.

Fixes #18871

@jchv jchv requested a review from jelbourn as a code owner March 23, 2020 17:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2020
feat(material/icon): allow fetching icons with credentials
dbf7520 
Adds the ability to fetch SVG icons using withCredentials.

Fixes angular#18871
@jchv jchv force-pushed the feat/icon/withCredentials branch from a00e256 to dbf7520 Compare March 23, 2020 17:20
crisbeto
crisbeto approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Mar 24, 2020
jelbourn
jelbourn approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 77730e9 into angular:master Apr 8, 2020
@jchv jchv deleted the feat/icon/withCredentials branch April 8, 2020 09:41
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 9, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fr(material/icon): Support fetching icons with credentials

5 participants

@jchv @jelbourn @crisbeto @googlebot @mmalerba