Skip to content

fix(list): don't select disabled options when pressing ctrl + a #18885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix(list): don't select disabled options when pressing ctrl + a #18885

merged 1 commit into from
Apr 20, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 22, 2020

Fixes disabled options being selected when the user presses ctrl + a. Selecting disabled options is still supported through selectAll.

@crisbeto
fix(list): don't select disabled options when pressing ctrl + a
a896cc7 
Fixes disabled options being selected when the user presses ctrl + a. Selecting disabled options is still supported through `selectAll`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 22, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 22, 2020
@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 23, 2020
jelbourn
jelbourn approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 77f65e3 into angular:master Apr 20, 2020
jelbourn pushed a commit that referenced this pull request Apr 20, 2020
@crisbeto @jelbourn
fix(list): don't select disabled options when pressing ctrl + a (#18885)
087ed4a 
Fixes disabled options being selected when the user presses ctrl + a. Selecting disabled options is still supported through `selectAll`.

(cherry picked from commit 77f65e3)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
fix(list): don't select disabled options when pressing ctrl + a (angu…
9a19a61 
…lar#18885)

Fixes disabled options being selected when the user presses ctrl + a. Selecting disabled options is still supported through `selectAll`.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 21, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @devversion @googlebot