Skip to content

demo(mdc-list): Add a demo page for the MDC-based list #18604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2020
Merged

demo(mdc-list): Add a demo page for the MDC-based list #18604

merged 5 commits into from
Feb 26, 2020

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 25, 2020

Currently blocked on http://cl/296322757 which fixes a unit mismatch issue between our typography system and MDC's Sass

@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Feb 25, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 25, 2020
crisbeto
crisbeto approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba requested a review from a team as a code owner February 25, 2020 19:23
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe target: patch This PR is targeted for the next patch release and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Feb 26, 2020
@mmalerba mmalerba merged commit 9343d08 into angular:master Feb 26, 2020
@mmalerba mmalerba deleted the mdc-list branch February 26, 2020 20:23
jelbourn pushed a commit that referenced this pull request Mar 3, 2020
@mmalerba @jelbourn
demo(mdc-list): Add a demo page for the MDC-based list (#18604)
b3d8315 
* 3.3. Add a demo page for the MDC-based list.

* WIP: css

* fix lint

* update MDC to version with fix

* fix some CSS styles

(cherry picked from commit 9343d08)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 28, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmalerba @crisbeto @googlebot