Skip to content

fix(material-experimental/mdc-chips): align with latest MDC markup #18472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2020
Merged

fix(material-experimental/mdc-chips): align with latest MDC markup #18472

merged 1 commit into from
Feb 26, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 12, 2020

Aligns the MDC-based chips with the latest MDC markup. Also bumps to the latest MDC Canary version.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 12, 2020
@crisbeto crisbeto requested review from a team, jelbourn and mmalerba as code owners February 12, 2020 12:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 12, 2020
@andrewseguin
Copy link
Contributor

andrewseguin commented Feb 20, 2020

Internal tests pass, but needs rebase

@crisbeto
fix(material-experimental/mdc-chips): align with latest MDC markup
716ab06 
Aligns the MDC-based chips with the latest MDC markup. Also bumps to the latest MDC Canary version.
@crisbeto crisbeto force-pushed the mdc-chips-markup-update branch from 7bde457 to 716ab06 Compare February 22, 2020 13:51
@crisbeto
Copy link
Member Author

crisbeto commented Feb 22, 2020

Rebased.

@jelbourn jelbourn merged commit 433da58 into angular:master Feb 26, 2020
jelbourn pushed a commit that referenced this pull request Mar 3, 2020
@crisbeto @jelbourn
fix(material-experimental/mdc-chips): align with latest MDC markup (#…
7db3e3a 
…18472)

Aligns the MDC-based chips with the latest MDC markup. Also bumps to the latest MDC Canary version.

(cherry picked from commit 433da58)
This was referenced Mar 11, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2020
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 28, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto @andrewseguin @devversion @mmalerba @jelbourn @googlebot