Skip to content

docs: responsiveness of autocomplete examples tab #18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2019
Merged

docs: responsiveness of autocomplete examples tab #18007

merged 1 commit into from
Dec 19, 2019

Conversation

@RudarDaman
Copy link
Contributor

@RudarDaman RudarDaman commented Dec 19, 2019

Screenshot from 2019-12-19 12-22-51
The above issue is resolved directly on https://material.angular.io/components/autocomplete/examples

@RudarDaman RudarDaman requested a review from jelbourn as a code owner December 19, 2019 06:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 19, 2019
crisbeto
crisbeto approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Dec 19, 2019
@crisbeto
Copy link
Member

crisbeto commented Dec 19, 2019

Commit message fixup: should be docs, not fix.

@RudarDaman RudarDaman changed the title fix: responsiveness of autocomplete examples tab docs: responsiveness of autocomplete examples tab Dec 19, 2019
@RudarDaman
Copy link
Contributor Author

RudarDaman commented Dec 19, 2019

@crisbeto I have updated the commit message. Thanks for the commit message suggestion.

@crisbeto crisbeto removed the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Dec 19, 2019
@andrewseguin andrewseguin merged commit 050ee7a into angular:master Dec 19, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jan 19, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2020
@RudarDaman RudarDaman deleted the responsiveness-autocomplete-examples branch January 21, 2020 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RudarDaman @crisbeto @devversion @googlebot @andrewseguin