Skip to content

refactor: remove ts 3.7 compatibility type cast in ripple-renderer #17934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2019
Merged

refactor: remove ts 3.7 compatibility type cast in ripple-renderer #17934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/material/core/ripple/ripple-renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,12 @@ export class RippleRenderer {
ripple.style.height = `${radius * 2}px`;
ripple.style.width = `${radius * 2}px`;

// If the color is not set, the default CSS color will be used.
// TODO(TS3.7): Type 'string | null' is not assignable to type 'string'.
ripple.style.backgroundColor = (config.color || null) as any;
// If a custom color has been specified, set it as inline style. If no color is
// set, the default color will be applied through the ripple theme styles.
if (config.color != null) {
ripple.style.backgroundColor = config.color;
}

ripple.style.transitionDuration = `${duration}ms`;

this._containerElement.appendChild(ripple);
Expand Down