feat(table): add test harness #17799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
a team,
andrewseguin and
jelbourn
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
a9bdd18 to
d5adcec
Compare
jelbourn
reviewed
Nov 25, 2019
mmalerba
reviewed
Nov 25, 2019
mmalerba
reviewed
Nov 25, 2019
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
d5adcec to
f2475cd
Compare
jelbourn
reviewed
Dec 2, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
I talked with @andrewseguin about this for a while we we decided we want to talk about the getText APIs at the team meeting this week
Adds a test harness for `MatTable`, as well as the related row and cell directives.
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
f2475cd to
cc35d28
Compare
Member
Author
jelbourn
approved these changes
Dec 16, 2019
| /** Gets the text of the cells in the row. */ | ||
| async getCellTextByIndex(filter: CellHarnessFilters = {}): Promise<string[]> { | ||
| return getCellTextByIndex(this, filter); | ||
| } |
Member
There was a problem hiding this comment.
I think we decided to add getCellTextByColumnName to the row as well, but that could always be added in a follow-up
Member
Author
There was a problem hiding this comment.
Added to my list to do in a follow-up PR.
jelbourn
added
pr: lgtm
action: merge
mmalerba
reviewed
Dec 16, 2019
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
cc35d28 to
2357502
Compare
mmalerba
reviewed
Dec 18, 2019
mmalerba
reviewed
Dec 18, 2019
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
2357502 to
059ee0e
Compare
Member
Author
|
Addressed the latest set of feedback. |
Adds a test harness for `MatTable`, as well as the related row and cell directives.
crisbeto
force-pushed
the
COMP-197/table-harness
branch
from
059ee0e to
a6f4c74
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 21, 2019
…in harness Follow-up from the feedback in angular#17799. Adds a `getCellTextByColumnName` to the `MatRowHarness` which aligns with what we have on the table harness.
mmalerba
pushed a commit
that referenced
this pull request
Dec 29, 2019
Follow-up from the feedback in #17799. Adds a `getCellTextByColumnName` to the `MatRowHarness` which aligns with what we have on the table harness.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test harness for
MatTable, as well as the related row and cell directives.