Skip to content

Conversation

@jelbourn
Copy link
Member

This reverts commit 022acf8.

Reverting this fixed the npm package build being broken.

This reverts commit 022acf8.

Reverting this fixed the npm package build being broken.
@jelbourn jelbourn added pr: merge safe target: major This PR is targeted for the next major release labels Nov 21, 2019
@jelbourn jelbourn requested a review from a team as a code owner November 21, 2019 18:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2019
@jelbourn
Copy link
Member Author

Joey is currently testing this in a clean repo to confirm it fixes the problem

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 21, 2019
@mmalerba mmalerba merged commit 49527e5 into angular:master Nov 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants