Skip to content

refactor: update to MDC 4.0.0 stable #17633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

refactor: update to MDC 4.0.0 stable #17633

merged 1 commit into from
Nov 7, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 6, 2019

Updates the repo to MDC 4.0.0 stable and fixes the breaking changes.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Nov 6, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Nov 6, 2019
@crisbeto crisbeto requested review from a team, andrewseguin and jelbourn as code owners November 6, 2019 23:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 6, 2019
@crisbeto crisbeto force-pushed the mdc-4.0.0-stable branch 2 times, most recently from 3e88ac2 to 3d830de Compare November 6, 2019 23:36
@mmalerba
Copy link
Contributor

mmalerba commented Nov 7, 2019

looks like there's one failing test for progress bar

@crisbeto
refactor: update to MDC 4.0.0 stable
6463e14 
Updates the repo to MDC 4.0.0 stable and fixes the breaking changes.
@crisbeto
Copy link
Member Author

crisbeto commented Nov 7, 2019

The tests should be sorted out now.

devversion
devversion approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 This should finally make master green!

josephperrott
josephperrott approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 466903e into angular:master Nov 7, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@crisbeto @mmalerba @devversion @josephperrott @jelbourn @googlebot