refactor(cdk/overlay): remove deprecated connected position strategy #17519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P1
googlebot
added
the
cla: yes
|
Caretaker note: let's decide how to proceed with this one based on the number of usages we see in g3. |
crisbeto
force-pushed
the
remove-connected-position-strategy
branch
from
623d0bd to
56fdba5
Compare
jelbourn
added
P2
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 8, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
force-pushed
the
remove-connected-position-strategy
branch
from
56fdba5 to
f96fb83
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 8, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 17, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 17, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 23, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
annieyw
pushed a commit
that referenced
this pull request
Sep 23, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Sep 24, 2020
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
|
Was there already a migration for this applied in a previous release? |
|
There's no easy way to migrate this for people. The position strategy has been deprecated since March 2018 so there's been a lot of time to migrate away from it. |
crisbeto
changed the title
crisbeto
changed the title
crisbeto
force-pushed
the
remove-connected-position-strategy
branch
from
f96fb83 to
19a1178
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
Removes most of the deprecated APIs for v11 under `cdk/overlay`. Note that these changes target primarily the breaking changes that should be easier to land. I've left out removing `ConnectedPositionStrategy` which has a separate PR (angular#17519), and `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height`, because they'll be trickier to land. BREAKING CHANGES: * The `OVERLAY_PROVIDERS` constant has been removed. Import `OverlayModule` and use the providers directly instead. * `_platform` parameter of the `OverlayContainer` constructor is now required. * `_platform` parameter of the `FullscreenOverlayContainer` constructor is now required. * `_location` and `_outsideClickDispatcher` parameters of the `OverlayRef` constructor are now required. * `_location` and `_outsideClickDispatcher` parameters of the `Overlay` constructor are now required.
crisbeto
force-pushed
the
remove-connected-position-strategy
branch
from
19a1178 to
3f43275
Compare
The `ConnectedPositionStrategy` has been deprecated since at least 7.0.0 and is just a wrapper around `FlexibleConnectedPositionStrategy`. These changes remove it since it still adds a fair bit of code that has to be maintained. BREAKING CHANGE: * `ConnectedPositionStrategy` has been removed. Use `FlexibleConnectedPositionStrategy` instead. * `OverlayPositionBuilder.connectedTo` has been removed. Use `OverlayPositionBuilder.flexibleConnectedTo` instead.
crisbeto
force-pushed
the
remove-connected-position-strategy
branch
from
3f43275 to
babd9de
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConnectedPositionStrategyhas been deprecated since at least 7.0.0 and is just a wrapper aroundFlexibleConnectedPositionStrategy. These changes remove it since it still adds a fair bit of code that has to be maintained.BREAKING CHANGE:
ConnectedPositionStrategyhas been removed. UseFlexibleConnectedPositionStrategyinstead.OverlayPositionBuilder.connectedTohas been removed. UseOverlayPositionBuilder.flexibleConnectedToinstead.