Skip to content

fix(sidenav): container not picking up indirect descendant sidenavs #17453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

fix(sidenav): container not picking up indirect descendant sidenavs #17453

merged 1 commit into from
Oct 21, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 20, 2019

Fixes the sidenav container not picking up indirect descendant sidenavs.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Oct 20, 2019
@crisbeto crisbeto added this to the 9.0.0 milestone Oct 20, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner October 20, 2019 17:05
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2019
crisbeto
crisbeto commented Oct 20, 2019
View reviewed changes
@crisbeto crisbeto changed the title fix(sidenav): contaienr not picking up indirect descendant sidenavs fix(sidenav): container not picking up indirect descendant sidenavs Oct 20, 2019
@crisbeto crisbeto force-pushed the drawer-indirect-descendants branch 2 times, most recently from 19243a8 to 34f27f5 Compare October 21, 2019 18:46
@crisbeto
Copy link
Member Author

crisbeto commented Oct 21, 2019

@mmalerba I expanded the changes to handle nested containers. Can you take another look?

@crisbeto crisbeto force-pushed the drawer-indirect-descendants branch from 34f27f5 to f4e3776 Compare October 21, 2019 19:01
@crisbeto
fix(sidenav): container not picking up indirect descendant sidenavs
41a598d 
Fixes the sidenav container not picking up indirect descendant sidenavs.
@crisbeto crisbeto force-pushed the drawer-indirect-descendants branch from f4e3776 to 41a598d Compare October 21, 2019 19:28
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 21, 2019
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 21, 2019
@mmalerba mmalerba merged commit 9933479 into angular:master Oct 21, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 21, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @mmalerba @googlebot