Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 1, 2019

Adds MAT_MOMENT_DATE_ADAPTER_OPTIONS to the deps array in all the examples that use MomentDateAdapter. The token is technically an optional dependency, however people tend to copy things verbatim from the docs and they might miss that the token needs to be added (see #17235).

Adds `MAT_MOMENT_DATE_ADAPTER_OPTIONS` to the `deps` array in all the examples that use `MomentDateAdapter`. The token is technically an optional dependency, however people tend to copy things verbatim from the docs and they might miss that the token needs to be added (see angular#17235).
@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 1, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner October 1, 2019 19:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 1, 2019
@mmalerba mmalerba merged commit 9586b5c into angular:master Oct 1, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
Adds `MAT_MOMENT_DATE_ADAPTER_OPTIONS` to the `deps` array in all the examples that use `MomentDateAdapter`. The token is technically an optional dependency, however people tend to copy things verbatim from the docs and they might miss that the token needs to be added (see #17235).

(cherry picked from commit 9586b5c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants