fix(cdk-experimental/clipboard): avoid changing layout with temporary textarea #17227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… textarea Currently the clipboard service creates a temporary invisible `textarea` from which to copy the text into the clipboard, however since it only has `opacity: 0`, it has the potential of changing the layout in a noticeable way if it is present for longer. These changes add some extra styles to avoid changing the layout. I also did some small cleanup to make it a bit more robust.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
approved these changes
Sep 30, 2019
| // absolute position so the page layout isn't affected. | ||
| styles.opacity = '0'; | ||
| styles.position = 'absolute'; | ||
| styles.left = styles.top = '-999em'; |
Member
There was a problem hiding this comment.
Just out of curiosity: why em?
Member
Author
There was a problem hiding this comment.
No particular reason. I just wanted to make sure that it's off-screen so I put in something that is guaranteed to be large.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Sep 30, 2019
… textarea (#17227) Currently the clipboard service creates a temporary invisible `textarea` from which to copy the text into the clipboard, however since it only has `opacity: 0`, it has the potential of changing the layout in a noticeable way if it is present for longer. These changes add some extra styles to avoid changing the layout. I also did some small cleanup to make it a bit more robust. (cherry picked from commit 17f2546)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the clipboard service creates a temporary invisible
textareafrom which to copy the text into the clipboard, however since it only hasopacity: 0, it has the potential of changing the layout in a noticeable way if it is present for longer.These changes add some extra styles to avoid changing the layout. I also did some small cleanup to make it a bit more robust.