Skip to content

build: remove infinite import loops #17060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

build: remove infinite import loops #17060

merged 1 commit into from
Sep 11, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 11, 2019

Fixes some more infinite loops due to a package that tries to import itself.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 11, 2019
@crisbeto
build: remove infinite import loops
e016aec 
Fixes some more infinite loops due to a package that tries to import itself.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 11, 2019
@crisbeto crisbeto marked this pull request as ready for review September 11, 2019 19:56
@crisbeto crisbeto requested a review from a team as a code owner September 11, 2019 19:56
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 11, 2019
@andrewseguin andrewseguin merged commit 31d8819 into angular:master Sep 11, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
@crisbeto @jelbourn
build: remove infinite import loops (angular#17060)
75231d6 
Fixes some more infinite loops due to a package that tries to import itself.

(cherry picked from commit 31d8819)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @googlebot @andrewseguin