Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 4, 2019

This should have been included as part of #16709, but got overlooked
somehow

…essEnvironment`

This should have been included as part of angular#16709, but got overlooked
somehow
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 4, 2019
@devversion
Copy link
Member

Isn't this supposed to be addressed by #16903?

@mmalerba
Copy link
Contributor Author

mmalerba commented Sep 4, 2019

Ah, yeah the dialog one just shouldn't have gone in before that one. Please rebase #16903 to add back the protected on the constructor and I'll close this one.

@mmalerba mmalerba closed this Sep 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants