build: bazel typescript targets should use tsickle for decorator processing #16906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/workaround-for-tsickle
branch
4 times, most recently
from
6c5d4b4 to
01ec26d
Compare
…essing We want to enable tsickle for decorator processing. This was one of the blockers for using the bazel packages in releases as unprocessed decorators will end up referencing DOM specific globals (e.g. `HTMLElement`). These references would then break server-side rendering for non CLI projects. Read more about this angular/angular#30586
devversion
force-pushed
the
build/workaround-for-tsickle
branch
from
01ec26d to
de2f8a9
Compare
devversion
added
pr: merge safe
target: patch
josephperrott
approved these changes
Aug 29, 2019
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable tsickle for decorator processing. This was one of the
blockers for using the bazel packages in releases as unprocessed decorators
will end up referencing DOM specific globals (e.g.
HTMLElement).These references would then break server-side rendering for non CLI
projects. Read more about this angular/angular#30586