Skip to content

Conversation

@mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Aug 27, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2019
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 27, 2019
@mmalerba
Copy link
Contributor Author

CARETAKER NOTE: CatalystHarnessEnvironment tests will need to be updated

@mmalerba mmalerba force-pushed the restrict-locator-for branch from a03a2c5 to 7985731 Compare August 27, 2019 20:55
@mmalerba mmalerba requested a review from a team August 27, 2019 20:55
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 27, 2019
@mmalerba mmalerba force-pushed the restrict-locator-for branch from 7985731 to 65f637c Compare August 27, 2019 20:57
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Aug 27, 2019
@mmalerba mmalerba added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 27, 2019
@mmalerba
Copy link
Contributor Author

As discussed with @jelbourn offline, refactored the API to be an option on HarnessPredicate rather than an additional parameter to locatorFor.

Currently blocked on #16848

@mmalerba mmalerba force-pushed the restrict-locator-for branch 3 times, most recently from d999924 to a852d29 Compare August 30, 2019 06:16
@mmalerba mmalerba force-pushed the restrict-locator-for branch from a852d29 to 8e2e248 Compare August 30, 2019 22:20
@mmalerba mmalerba removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Aug 30, 2019
@mmalerba
Copy link
Contributor Author

unblocked now that #16848 is in, PTAL

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 30, 2019
@ngbot
Copy link

ngbot bot commented Aug 30, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit fb5750b into angular:master Sep 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants