ci: temporarily disable gesture config tests #16828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
We need to temporarily disable the gesture tests in order to land a PR in framework that makes Hammer support optional (angular/angular#32203). Otherwise, the Material/FW integration tests will fail because Material modules haven't yet opted into Hammer. Unfortunately, we cannot yet fix this properly by adding the HammerModule to Material because Material is not using a release that has HammerModule. Once the PR lands and Material updates to a 9.0.0-next release, we can add the HammerModule properly and turn these tests back on.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
We need to temporarily disable the gesture tests in order to land a PR in framework that makes Hammer support optional (angular/angular#32203). Otherwise, the Material/FW integration tests will fail because Material modules haven't yet opted into Hammer. Unfortunately, we cannot yet fix this properly by adding the HammerModule to Material because Material is not using a release that has HammerModule. Once the PR lands and Material updates to a 9.0.0-next release, we can add the HammerModule properly and turn these tests back on. (cherry picked from commit eaf70ca)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to temporarily disable the gesture tests in order to
land a PR in framework that makes Hammer support optional
(angular/angular#32203). Otherwise,
the Material/FW integration tests will fail because Material
modules haven't yet opted into Hammer.
Unfortunately, we cannot yet fix this properly by adding the
HammerModule to Material because Material is not using a
release that has HammerModule. Once the PR lands and Material
updates to a 9.0.0-next release, we can add the HammerModule
properly and turn these tests back on.