fix(schematics): navigation schematic not respecting breakpoints on initial render #16788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitial render angular@a6cdcfc added the `share()` operator to the `isHandset$` observable. This accidentally broke the initial rendering of the navigation as the view subscribes to the observable (through `async` pipe) after the initial value has been emitted. Meaning that `isHandset$ | async` expression always evaluates to `null` until the breakpoint changes.
devversion
added
P3
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
…nitial render (#16788) a6cdcfc added the `share()` operator to the `isHandset$` observable. This accidentally broke the initial rendering of the navigation as the view subscribes to the observable (through `async` pipe) after the initial value has been emitted. Meaning that `isHandset$ | async` expression always evaluates to `null` until the breakpoint changes. (cherry picked from commit 3205b31)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a6cdcfc added the
share()operator to theisHandset$observable. This accidentallybroke the initial rendering of the navigation as the view subscribes to the observable
(through
asyncpipe) after the initial value has been emitted. Meaning thatisHandset$ | asyncexpression always evaluates to
nulluntil the breakpoint changes.