feat(material-experimental): add test harness for tabs #16728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 16, 2019
| * @return a `HarnessPredicate` configured with the given options. | ||
| */ | ||
| static with(options: TabGroupHarnessFilters = {}): HarnessPredicate<MatTabGroupHarness> { | ||
| return new HarnessPredicate(MatTabGroupHarness); |
Member
There was a problem hiding this comment.
For a follow up: I could see having a filter for the selected tab label
mmalerba
reviewed
Aug 16, 2019
devversion
force-pushed
the
feat/harness-tabs
branch
from
f99d664 to
f69302b
Compare
mmalerba
approved these changes
Aug 16, 2019
Contributor
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
Looks good aside from the broken import
Resolves COMP-193.
devversion
force-pushed
the
feat/harness-tabs
branch
from
f69302b to
6695eca
Compare
Member
Author
|
Ops. looks like I forgot pushing the new file for the tab-label class. Pushed now. |
mmalerba
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 19, 2019
…lected tab Follow-up that addresses feedback from the original tab-group harness PR. See: angular#16728#discussion_r314819393
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 19, 2019
…lected tab Follow-up that addresses feedback from the original tab-group harness PR. See: angular#16728#discussion_r314819393
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 19, 2019
…lected tab Follow-up that addresses feedback from the original tab-group harness PR. See: angular#16728#discussion_r314819393
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves COMP-193.