fix(material-experimental/mdc-chips): incorrect selector for mdc-chip-avatar #16722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
P3
googlebot
added
the
cla: yes
andrewseguin
added
the
merge: fix commit message
| </svg> | ||
| <div class="mdc-chip__text"><ng-content></ng-content></div> | ||
| <ng-content select="[mat-chip-trailing-icon],[matChipRemove],[matChipTrailingIcon]"></ng-content> | ||
| <ng-content select="[mat-chip-trailing-icon],[matChipRemove],[matChipTrailingIcon]"></ng-content> |
Collaborator
There was a problem hiding this comment.
Do you need to remove the square brackets around [mat-chip-trailing-icon] as well?
Contributor
Author
There was a problem hiding this comment.
Yes good catch, just made that change as well
… for avatar, icon
andrewseguin
force-pushed
the
mdc-chip-avatar
branch
from
6b93e5b to
905652e
Compare
andrewseguin
changed the title
mmalerba
pushed a commit
that referenced
this pull request
Aug 14, 2019
(cherry picked from commit 2994365)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector for
MatChipAvataris:'mat-chip-avatar, [matChipAvatar]'Chips are selecting
[mat-chip-avatar]instead ofmat-chip-avatar, causing incorrect styling on the rendered chips