Skip to content

feat(cdk-experimental/testing): Improve keyboard event support in harnesses #16645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2019
Merged

feat(cdk-experimental/testing): Improve keyboard event support in harnesses #16645

merged 6 commits into from
Aug 12, 2019

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 30, 2019

existing tests and the test harnesses.

Also adds API for more easily sending special keys that don't result in
a character being typed

@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 30, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 30, 2019
@mmalerba
Copy link
Contributor Author

mmalerba commented Jul 30, 2019

Actually don't review just yet, I might have to change some things to make sure it works with protractor too

@mmalerba mmalerba force-pushed the keycode branch 3 times, most recently from f120138 to 0045fb2 Compare August 2, 2019 00:01
@mmalerba mmalerba changed the title refactor(cdk/testing): share code for sending key events between our feat(cdk-experimental/testing): Improve keyboard event support in harnesses Aug 2, 2019
@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 2, 2019

Ok, PTAL

devversion
devversion approved these changes Aug 3, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉 A few minor comments.

@devversion devversion mentioned this pull request Aug 3, 2019
Merged
devversion
devversion approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a blocker for #16674 and #16709 so it would be good to get this in.

@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm labels Aug 7, 2019
@devversion devversion mentioned this pull request Aug 7, 2019
Merged
@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 7, 2019

I would like @jelbourn to take a look and make sure he's ok with the approach I'm taking here

@devversion
Copy link
Member

devversion commented Aug 7, 2019

@mmalerba Yeah I assumed that. That's why I didn't add the merge ready label.

jelbourn
jelbourn approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmalerba added 6 commits August 8, 2019 16:16
@mmalerba
feat(cdk-experimental/testing): Improve keyboard event support in har…
a880dd0 
…nesses

- Adds support for special keys like <kbd>ENTER</kbd>, <kbd>ESCAPE</kbd>, etc.
- Adds support for modifier keys (e.g. <kbd>SHIFT</kbd>, etc.)
- Improve code sharing for sending key events between our existing tests and the test harnesses.
@mmalerba
Add support for modifier keys to typeInElement
695e41c
@mmalerba
add better key support to harnesses
59d265c
@mmalerba
fix lint
f3080eb
@mmalerba
address feedback
6e9ad23
@mmalerba
address feedback
255a128
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe and removed pr: merge safe labels Aug 12, 2019
@mmalerba mmalerba merged commit 286038c into angular:master Aug 12, 2019
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mmalerba @devversion @jelbourn @crisbeto @googlebot @andrewseguin