Skip to content

feat(material-experimental): add progress spinner test harness skeleton #16622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 6, 2019
Merged

feat(material-experimental): add progress spinner test harness skeleton #16622

merged 5 commits into from
Aug 6, 2019

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jul 26, 2019

No description provided.

@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 26, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 26, 2019
@andrewseguin andrewseguin force-pushed the harness-progress-spinner branch from 25fe491 to 345a064 Compare July 26, 2019 21:14
@andrewseguin andrewseguin requested a review from jelbourn as a code owner July 26, 2019 21:14
@andrewseguin andrewseguin force-pushed the harness-progress-spinner branch from 345a064 to f38330b Compare July 26, 2019 21:19
jelbourn
jelbourn approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 29, 2019
@mmalerba mmalerba merged commit 725a2b3 into angular:master Aug 6, 2019
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
@andrewseguin @mmalerba
feat(material-experimental): add progress spinner test harness… (#16622)
7c7217e 
* feat(material-experimental): add progress spinner test harness skeleton

* use number coercion

* fix build

* address feedback

(cherry picked from commit 725a2b3)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewseguin @jelbourn @googlebot @mmalerba