feat(material-experimental): add test harness for button #16556
Conversation
jelbourn
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
| <button id="fab" type="button" mat-fab>Fab button</button> | ||
| <button id="mini-fab" type="button" mat-mini-fab>Mini Fab button</button> | ||
|
|
||
| <a id="anchor-basic" type="button" mat-button>Basic anchor</a> |
There was a problem hiding this comment.
Links don't have a type attribute.
| * @dynamic | ||
| */ | ||
| export class MatButtonHarness extends ComponentHarness { | ||
| static hostSelector = [ |
There was a problem hiding this comment.
There's an array of these defined as BUTTON_HOST_ATTRIBUTES. Could we export and re-use it here? Otherwise we'll have to remember to update this array if we add more button types.
There was a problem hiding this comment.
I really just want to change this to use e.g. .mat-button-base, which was in another PR when I wrote this. Added a TODO for now
| } | ||
|
|
||
| /** Gets a promise for the button's name. */ | ||
| async getName(): Promise<string | null> { |
There was a problem hiding this comment.
Is getting the name of a button common enough for it to have it's own method? We could expose a getAttribute instead which would cover more cases.
There was a problem hiding this comment.
Removed. I was on the fence myself, having just left it in there from checkbox
| * @dynamic | ||
| */ | ||
| export class MatButtonHarness extends ComponentHarness { | ||
| static hostSelector = [ |
There was a problem hiding this comment.
Same as the comment above importing these
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM aside from @crisbeto's comments. One question though: why do we put in the standard button harness into the mdc-button entry-point?
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
Comments addressed, added code to skip the disabled click test for Edge
| * @dynamic | ||
| */ | ||
| export class MatButtonHarness extends ComponentHarness { | ||
| static hostSelector = [ |
There was a problem hiding this comment.
I really just want to change this to use e.g. .mat-button-base, which was in another PR when I wrote this. Added a TODO for now
| } | ||
|
|
||
| /** Gets a promise for the button's name. */ | ||
| async getName(): Promise<string | null> { |
There was a problem hiding this comment.
Removed. I was on the fence myself, having just left it in there from checkbox
| * @dynamic | ||
| */ | ||
| export class MatButtonHarness extends ComponentHarness { | ||
| static hostSelector = [ |
jelbourn
force-pushed
the
button-harness
branch
2 times, most recently
from
33f61b0 to
c8414a7
Compare
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
LGTM asside from comment nits
| /** | ||
| * Gets a `HarnessPredicate` that can be used to search for a button with specific attributes. | ||
| * @param options Options for narrowing the search: | ||
| * - `label` finds a button with specific label text. |
| /** | ||
| * Gets a `HarnessPredicate` that can be used to search for a button with specific attributes. | ||
| * @param options Options for narrowing the search: | ||
| * - `label` finds a button with specific label text. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.